Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make lint-fix is broken #11284

Closed
4 tasks
de-husk opened this issue Feb 26, 2022 · 0 comments · Fixed by #11285
Closed
4 tasks

Make lint-fix is broken #11284

de-husk opened this issue Feb 26, 2022 · 0 comments · Fixed by #11285

Comments

@de-husk
Copy link
Contributor

de-husk commented Feb 26, 2022

Summary of Bug

The lint-fix make target is not working on latest master.

[~/cosmos/cosmos-sdk]> make lint-fix
Makefile:71: RocksDB support is disabled; to build and test with RocksDB support, set ENABLE_ROCKSDB=true
make: *** No rule to make target `install-golangci-lint', needed by `lint-fix'.  Stop.

Version

master (and v0.46.0 alpha releases)

Steps to Reproduce

Run make lint-fix locally.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@de-husk de-husk mentioned this issue Feb 26, 2022
Merged
19 tasks
@mergify mergify bot closed this as completed in #11285 Feb 28, 2022
mergify bot pushed a commit that referenced this issue Feb 28, 2022
@de-husk
fix: lint-fix make target error (#11285)
8760ae3 
## Description

Closes: #11284



This make target was erroring since it was referencing something that didn't exist anymore. Devs are responsible for installing `golangci-lint` on their own now.

---

### Author Checklist

*All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.*

I have...

- [x] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] added `!` to the type prefix if API or client breaking change
- [x] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting))
- [x] provided a link to the relevant issue or specification
- [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules)
- [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing)
- [x] added a changelog entry to `CHANGELOG.md`
- [ ] included comments for [documenting Go code](https://blog.golang.org/godoc)
- [ ] updated the relevant documentation or specification
- [ ] reviewed "Files changed" and left comments if necessary
- [ ] confirmed all CI checks have passed

### Reviewers Checklist

*All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.*

I have...

- [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] confirmed `!` in the type prefix if API or client breaking change
- [ ] confirmed all author checklist items have been addressed 
- [ ] reviewed state machine logic
- [ ] reviewed API design and naming
- [ ] reviewed documentation is accurate
- [ ] reviewed tests and test coverage
- [ ] manually tested (if applicable)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
No open projects
Cosmos SDK Maintenance
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: lint-fix make target error de-husk/cosmos-sdk
1 participant
@de-husk