Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update gov simulations to use v1beta2.Proposal #10986

Closed
4 tasks
amaury1093 opened this issue Jan 20, 2022 · 0 comments · Fixed by #11069
Closed
4 tasks

Update gov simulations to use v1beta2.Proposal #10986

amaury1093 opened this issue Jan 20, 2022 · 0 comments · Fixed by #11069
Assignees
@atheeshp
Labels
C:Simulations C:x/gov

Comments

@amaury1093
Copy link
Contributor

amaury1093 commented Jan 20, 2022 •
edited
Loading

Summary

Current gov simulations use v1beta1. We should use v1beta2.

ref: #10868 (comment)

Proposal

Switch all v1beta1.Proposal to v1beta2. Same for MsgSubmitProposal. Make sure sims pass with v1beta2.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@amaury1093 amaury1093 mentioned this issue Jan 20, 2022
Merged
19 tasks
@atheeshp atheeshp mentioned this issue Jan 31, 2022
Merged
19 tasks
@mergify mergify bot closed this as completed in #11069 Feb 2, 2022
mergify bot pushed a commit that referenced this issue Feb 2, 2022
@atheeshp
refactor: gov sims to use v1beta2 (#11069)
0950146 
## Description

Closes: #10986 



---

### Author Checklist

*All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.*

I have...

- [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] added `!` to the type prefix if API or client breaking change
- [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting))
- [ ] provided a link to the relevant issue or specification
- [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules)
- [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing)
- [ ] added a changelog entry to `CHANGELOG.md`
- [ ] included comments for [documenting Go code](https://blog.golang.org/godoc)
- [ ] updated the relevant documentation or specification
- [ ] reviewed "Files changed" and left comments if necessary
- [ ] confirmed all CI checks have passed

### Reviewers Checklist

*All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.*

I have...

- [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] confirmed `!` in the type prefix if API or client breaking change
- [ ] confirmed all author checklist items have been addressed 
- [ ] reviewed state machine logic
- [ ] reviewed API design and naming
- [ ] reviewed documentation is accurate
- [ ] reviewed tests and test coverage
- [ ] manually tested (if applicable)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@atheeshp atheeshp

Labels
C:Simulations C:x/gov
Projects
No open projects
Cosmos SDK: Gov & Group WG
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: gov sims to use v1beta2 cosmos/cosmos-sdk
2 participants
@amaury1093 @atheeshp