refactor(x/upgrade): audit changes (#16786)

(cherry picked from commit 1ce85e1)
cosmos · Jun 30, 2023 · e02c801 · e02c801
1 parent ce08c79
commit e02c801
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 22 deletions.
diff --git a/x/upgrade/keeper/msg_server.go b/x/upgrade/keeper/msg_server.go
@@ -22,7 +22,10 @@ func NewMsgServerImpl(k *Keeper) types.MsgServer {
 	}
 }
 
-var _ types.MsgServer = msgServer{}
+var (
+	_    types.MsgServer = msgServer{}
+	_, _ sdk.Msg         = &types.MsgSoftwareUpgrade{}, &types.MsgCancelUpgrade{}
+)
 
 // SoftwareUpgrade implements the Msg/SoftwareUpgrade Msg service.
 func (k msgServer) SoftwareUpgrade(goCtx context.Context, msg *types.MsgSoftwareUpgrade) (*types.MsgSoftwareUpgradeResponse, error) {
@@ -49,8 +52,7 @@ func (k msgServer) CancelUpgrade(ctx context.Context, msg *types.MsgCancelUpgrad
 		return nil, errors.Wrapf(gov.ErrInvalidSigner, "expected %s got %s", k.authority, msg.Authority)
 	}
 
-	sdkCtx := sdk.UnwrapSDKContext(ctx)
-	err := k.ClearUpgradePlan(sdkCtx)
+	err := k.ClearUpgradePlan(ctx)
 	if err != nil {
 		return nil, err
 	}

diff --git a/x/upgrade/types/msgs.go b/x/upgrade/types/msgs.go