Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for the glitch on page blocks being moved and resized #1896

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

kelanik8
Copy link
Contributor

The following changes are implemented

TODO: Summary

Changes in the user interface:

TODO: Add screenshots, recordings or remove this section

Checklist when submitting a final (!draft) PR

  • Commits are tidied up, squashed if needed and follow guidelines in CONTRIBUTING.md
  • Code builds
  • All existing tests pass
  • All new critical code is covered by tests
  • PR is linked to the relevant issue(s)
  • Rebased with the target branch

@kelanik8 kelanik8 requested a review from Fajfa August 29, 2024 09:23
@kelanik8 kelanik8 linked an issue Aug 29, 2024 that may be closed by this pull request
@@ -120,9 +118,9 @@ export default {
immediate: true,
deep: true,
handler (blocks) {
blocks = blocks.map(({ meta, xywh: [x, y, w, h] }, i) => {
blocks = blocks.map(({ title, meta, xywh: [x, y, w, h] }, i) => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whats up with the title here?

@kelanik8 kelanik8 force-pushed the 2023.9.x-bugfix-builder-pageblocks-glitch branch 2 times, most recently from 27ee773 to 1be6aa5 Compare August 29, 2024 09:53
@kelanik8 kelanik8 force-pushed the 2023.9.x-bugfix-builder-pageblocks-glitch branch from 1be6aa5 to d157579 Compare August 29, 2024 09:59
@kelanik8 kelanik8 merged commit d157579 into 2023.9.x Aug 29, 2024
11 checks passed
@kelanik8 kelanik8 deleted the 2023.9.x-bugfix-builder-pageblocks-glitch branch August 29, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check out why page blocks sometimes dont stay in place
2 participants