Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix-replace-confirmation-toggle #1845

Merged
merged 1 commit into from
Sep 17, 2024
Merged

Conversation

EmmyMay
Copy link
Contributor

@EmmyMay EmmyMay commented Jul 3, 2024

The following changes are implemented

TODO: Summary

Changes in the user interface:

TODO: Add screenshots, recordings or remove this section

Checklist when submitting a final (!draft) PR

  • Commits are tidied up, squashed if needed and follow guidelines in CONTRIBUTING.md
  • Code builds
  • All existing tests pass
  • All new critical code is covered by tests
  • PR is linked to the relevant issue(s)
  • Rebased with the target branch

@EmmyMay EmmyMay self-assigned this Jul 3, 2024
@EmmyMay EmmyMay requested a review from Fajfa July 3, 2024 04:22
@EmmyMay EmmyMay linked an issue Jul 3, 2024 that may be closed by this pull request
12 tasks
Copy link
Member

@Fajfa Fajfa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove all mentions of the old component as well please. Make it look like it never existed.

image
image

@EmmyMay EmmyMay force-pushed the fix-replace-confirmation-toggle branch from 6d6edbc to 0a58ce8 Compare September 17, 2024 13:33
@EmmyMay EmmyMay merged commit 97b966e into 2024.3.x Sep 17, 2024
12 checks passed
@EmmyMay EmmyMay deleted the fix-replace-confirmation-toggle branch September 17, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace confirmation-toggle on admin with c-input-confirm
2 participants