Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Postgres timestamp fields sort inconsistencies #1844

Merged
merged 1 commit into from
Jul 25, 2024
Merged

Fix Postgres timestamp fields sort inconsistencies #1844

merged 1 commit into from
Jul 25, 2024

Conversation

KinyaElGrande
Copy link
Contributor

Fixes: #1843

@KinyaElGrande KinyaElGrande changed the title Fix Postgres timestamp sort inconsistencies Fix Postgres timestamp fields sort inconsistencies Jul 1, 2024
tjerman
tjerman approved these changes Jul 2, 2024
View reviewed changes
Copy link
Member

@tjerman tjerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm but what about the other dialects? You've only updated psql from what I can see

@KinyaElGrande KinyaElGrande force-pushed the 2023.9.x-fix-postgres-timestamp-sort branch from dd05203 to 73c7dc1 Compare July 25, 2024 11:32
@KinyaElGrande KinyaElGrande merged commit 36faf60 into 2023.9.x Jul 25, 2024
12 checks passed
@KinyaElGrande KinyaElGrande deleted the 2023.9.x-fix-postgres-timestamp-sort branch July 25, 2024 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tjerman tjerman tjerman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sorting bug
2 participants
@KinyaElGrande @tjerman