Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add open in new tab on redirect WF prompts #1726

Merged
merged 1 commit into from
Mar 20, 2024
Merged

Add open in new tab on redirect WF prompts #1726

merged 1 commit into from
Mar 20, 2024

Conversation

KinyaElGrande
Copy link
Contributor

@KinyaElGrande KinyaElGrande commented Mar 7, 2024 •
edited
Loading

Ref: #1709

  • Add open in new tab and in modal redirects
  • Add prompt error notification.
  • Redirect in edit mode, If no recordID is provided in recordPage redirect.
  • Add default values on redirect and button variants

@KinyaElGrande KinyaElGrande requested a review from Fajfa March 7, 2024 09:29
@KinyaElGrande KinyaElGrande linked an issue Mar 7, 2024 that may be closed by this pull request
Redirect to URL in WF Prompts to open in a new tab #1709
Closed
@KinyaElGrande KinyaElGrande force-pushed the 2023.9.x-wf-prompts-link-new-tab branch 2 times, most recently from bb1e309 to 0a9bb6a Compare March 15, 2024 14:12
Fajfa
Fajfa requested changes Mar 18, 2024
View reviewed changes
lib/vue/src/components/prompts/definitions.ts Outdated Show resolved Hide resolved
lib/vue/src/components/prompts/kinds/index.ts Outdated Show resolved Hide resolved
lib/vue/src/components/prompts/kinds/index.ts Outdated Show resolved Hide resolved
Fajfa
Fajfa reviewed Mar 18, 2024
View reviewed changes
client/web/workflow/src/components/Configurator/Function.vue
@@ -520,7 +520,7 @@ export default {
target: param.name,
type: arg.type || this.paramTypes[func.ref][param.name][0],
valueType: this.getValueType(arg, arg.type || this.paramTypes[func.ref][param.name][0], input),
value: arg.value || null,
value: arg.value || input.default || null,
expr: arg.expr || arg.source || null,
required: param.required || false,
input,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make the c-input-select clearable

@KinyaElGrande KinyaElGrande force-pushed the 2023.9.x-wf-prompts-link-new-tab branch from bec85e1 to 691f4fe Compare March 18, 2024 14:09
@KinyaElGrande KinyaElGrande force-pushed the 2023.9.x-wf-prompts-link-new-tab branch from 6ad482e to d49dff6 Compare March 20, 2024 15:20
@KinyaElGrande KinyaElGrande merged commit dd98df5 into 2023.9.x Mar 20, 2024
12 checks passed
@KinyaElGrande KinyaElGrande deleted the 2023.9.x-wf-prompts-link-new-tab branch March 20, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fajfa Fajfa Fajfa requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Redirect to URL in WF Prompts to open in a new tab
2 participants
@KinyaElGrande @Fajfa