Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add interpolation for certain blocks #1590

Merged
merged 2 commits into from
Dec 20, 2023
Merged

Conversation

EmmyMay
Copy link
Contributor

@EmmyMay EmmyMay commented Dec 16, 2023

The following changes are implemented

TODO: Summary

Changes in the user interface:

TODO: Add screenshots, recordings or remove this section

Checklist when submitting a final (!draft) PR

  • Commits are tidied up, squashed if needed and follow guidelines in CONTRIBUTING.md
  • Code builds
  • All existing tests pass
  • All new critical code is covered by tests
  • PR is linked to the relevant issue(s)
  • Rebased with the target branch

closes #1570

@EmmyMay EmmyMay self-assigned this Dec 16, 2023
@EmmyMay EmmyMay requested a review from Fajfa December 16, 2023 00:06
@EmmyMay EmmyMay force-pushed the 2023.9.x-feature-interpolation branch from 36a45d7 to 9be17d4 Compare December 16, 2023 20:48
@Fajfa Fajfa force-pushed the 2023.9.x-feature-interpolation branch from 9be17d4 to 28196cd Compare December 19, 2023 16:05
@katrinDY
Copy link
Contributor

katrinDY commented Dec 20, 2023

MetricConfig

Screenshot 2023-12-20 at 13 12 21

Module field -> RecordConfig -> add ${userID} to Prefilter records -> try to add a record with value to the new field and get. This is probably fine but wanna double-check expected

Screenshot 2023-12-20 at 13 31 20

Err if value isn't found for diff PBs - this is expected because the blocks aren't added to record page

  • RecOrgConfig
Screenshot 2023-12-20 at 13 40 13
  • RLConfig
Screenshot 2023-12-20 at 13 41 21
  • ProgressConfig
Screenshot 2023-12-20 at 13 47 47
  • ContentConfig

5

  • AutomationConfig

6

  • PBConfig

7

@Fajfa Fajfa force-pushed the 2023.9.x-feature-interpolation branch from 28196cd to 71848a9 Compare December 20, 2023 12:24
@Fajfa Fajfa force-pushed the 2023.9.x-feature-interpolation branch from 71848a9 to 321e0ff Compare December 20, 2023 16:44
@Fajfa Fajfa merged commit 321e0ff into 2023.9.x Dec 20, 2023
1 check passed
@Fajfa Fajfa deleted the 2023.9.x-feature-interpolation branch December 20, 2023 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add interpolation to places it can be useful
3 participants