Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2023.9.x feature hints for performance impacting features #1490

Merged
merged 1 commit into from
Nov 1, 2023
Merged

2023.9.x feature hints for performance impacting features #1490

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion client/web/compose/src/components/Admin/Module/Records/ColumnPicker.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,12 +11,20 @@
id="columns"
size="lg"
scrollable
:title="$t('allRecords.columns.title')"
:ok-title="$t('general.label.saveAndClose')"
cancel-variant="link"
body-class="p-0"
title-class="d-flex align-items-center p-0"
@ok="onSave"
>
<template #modal-title>
{{ $t('allRecords.columns.title') }}
<c-hint
:tooltip="$t('allRecords.tooltip.configureColumns')"
icon-class="text-warning"
/>
</template>

<b-card-body
class="d-flex flex-column mh-100"
>
Expand Down
6 changes: 6 additions & 0 deletions client/web/compose/src/components/Admin/Module/UniqueValues.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
<template>
<div>
<c-hint
:tooltip="$t('tooltip.performance')"
icon-class="text-warning"
class="float-right"
/>

<div
v-for="(rule, index) in rules"
:key="index"
Expand Down
15 changes: 0 additions & 15 deletions client/web/compose/src/components/Common/Hint.c3.js
View file
Open in desktop

This file was deleted.

22 changes: 0 additions & 22 deletions client/web/compose/src/components/Common/Hint.vue
View file
Open in desktop

This file was deleted.

13 changes: 9 additions & 4 deletions client/web/compose/src/components/ModuleFields/Configurator/Record.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,15 @@
<template
v-if="selectedModule"
>
<b-form-group
:label="$t('kind.record.moduleField')"
label-class="text-primary"
>
<b-form-group label-class="d-flex align-items-center text-primary p-0">
<template #label>
{{ $t('kind.record.moduleField') }}
<c-hint
:tooltip="$t('kind.record.tooltip.moduleField')"
icon-class="text-warning"
/>
</template>

<b-form-select
v-model="f.options.labelField"
:options="fieldOptions"
Expand Down
97 changes: 50 additions & 47 deletions client/web/compose/src/components/ModuleFields/Configurator/validation.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,31 +5,27 @@
<b-form-group
:label="$t('sanitizers.label')"
label-size="lg"
label-class="text-primary"
label-class="d-flex align-items-center text-primary"
>
<template #label>
<div
class="d-flex"
>
{{ $t('sanitizers.label') }}

<b-button
variant="link"
class="p-0 ml-1 mr-auto"
@click="field.expressions.sanitizers.push('')"
>
{{ $t('sanitizers.add') }}
</b-button>
{{ $t('sanitizers.label') }}

<b-button
variant="link"
:href="`${documentationURL}#value-sanitizers`"
target="_blank"
class="p-0 ml-1"
>
{{ $t('sanitizers.examples') }}
</b-button>
</div>
<b-button
variant="link"
class="p-0 ml-1 mr-auto"
@click="field.expressions.sanitizers.push('')"
>
{{ $t('sanitizers.add') }}
</b-button>

<b-button
variant="link"
:href="`${documentationURL}#value-sanitizers`"
target="_blank"
class="p-0 ml-1"
>
{{ $t('sanitizers.examples') }}
</b-button>
</template>

<field-expressions
Expand All @@ -46,32 +42,28 @@

<b-form-group
label-size="lg"
label-class="text-primary"
label-class="d-flex text-primary"
class="mt-3"
>
<template #label>
<div
class="d-flex"
>
{{ $t('validators.label') }}

<b-button
variant="link"
class="p-0 ml-1 mr-auto"
@click="field.expressions.validators.push({ test: '', error: '' })"
>
{{ $t('sanitizers.add') }}
</b-button>
{{ $t('validators.label') }}

<b-button
variant="link"
:href="`${documentationURL}#value-validators`"
target="_blank"
class="p-0 ml-1"
>
{{ $t('sanitizers.examples') }}
</b-button>
</div>
<b-button
variant="link"
class="p-0 ml-1 mr-auto"
@click="field.expressions.validators.push({ test: '', error: '' })"
>
{{ $t('sanitizers.add') }}
</b-button>

<b-button
variant="link"
:href="`${documentationURL}#value-validators`"
target="_blank"
class="p-0 ml-1"
>
{{ $t('sanitizers.examples') }}
</b-button>
</template>

<field-expressions
Expand Down Expand Up @@ -121,8 +113,19 @@

<hr>

<div>
<h5>{{ $t('constraints.label') }}</h5>
<b-form-group
label-size="lg"
label-class="d-flex align-items-center text-primary"
class="mt-3"
>
<template #label>
{{ $t('constraints.label') }}
<c-hint
:tooltip="$t('constraints.tooltip.performance')"
icon-class="text-warning"
/>
</template>

<b-form-checkbox
v-model="fieldConstraint.exists"
class="mt-3"
Expand Down Expand Up @@ -173,7 +176,7 @@
</i>
</b-col>
</b-row>
</div>
</b-form-group>
</div>
</template>

Expand Down
8 changes: 2 additions & 6 deletions client/web/compose/src/components/ModuleFields/Editor/Bool.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,7 @@
{{ label }}
</span>

<hint
:text="hint"
/>
<c-hint :tooltip="hint" />

<slot name="tools" />
</div>
Expand All @@ -46,9 +44,7 @@
>
{{ label }}

<hint
:text="hint"
/>
<c-hint :tooltip="hint" />
</div>
</c-input-checkbox>

Expand Down
4 changes: 1 addition & 3 deletions client/web/compose/src/components/ModuleFields/Editor/DateTime.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,7 @@
{{ label }}
</span>

<hint
:text="hint"
/>
<c-hint :tooltip="hint" />

<slot name="tools" />
</div>
Expand Down
4 changes: 1 addition & 3 deletions client/web/compose/src/components/ModuleFields/Editor/Email.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,7 @@
{{ label }}
</span>

<hint
:text="hint"
/>
<c-hint :tooltip="hint" />

<slot name="tools" />
</div>
Expand Down
4 changes: 1 addition & 3 deletions client/web/compose/src/components/ModuleFields/Editor/File.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,7 @@
{{ label }}
</span>

<hint
:text="hint"
/>
<c-hint :tooltip="hint" />

<slot name="tools" />
</div>
Expand Down
4 changes: 1 addition & 3 deletions client/web/compose/src/components/ModuleFields/Editor/Geometry.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,7 @@
{{ label }}
</span>

<hint
:text="hint"
/>
<c-hint :tooltip="hint" />

<slot name="tools" />
</div>
Expand Down
4 changes: 1 addition & 3 deletions client/web/compose/src/components/ModuleFields/Editor/Number.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,7 @@
{{ label }}
</span>

<hint
:text="hint"
/>
<c-hint :tooltip="hint" />

<slot name="tools" />
</div>
Expand Down
4 changes: 1 addition & 3 deletions client/web/compose/src/components/ModuleFields/Editor/Record.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,7 @@
{{ label }}
</span>

<hint
:text="hint"
/>
<c-hint :tooltip="hint" />

<slot name="tools" />
</div>
Expand Down
4 changes: 1 addition & 3 deletions client/web/compose/src/components/ModuleFields/Editor/Select.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,7 @@
{{ label }}
</span>

<hint
:text="hint"
/>
<c-hint :tooltip="hint" />

<slot name="tools" />
</div>
Expand Down
4 changes: 1 addition & 3 deletions client/web/compose/src/components/ModuleFields/Editor/String.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,7 @@
{{ label }}
</span>

<hint
:text="hint"
/>
<c-hint :tooltip="hint" />

<slot name="tools" />
</div>
Expand Down
4 changes: 1 addition & 3 deletions client/web/compose/src/components/ModuleFields/Editor/Url.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,7 @@
{{ label }}
</span>

<hint
:text="hint"
/>
<c-hint :tooltip="hint" />

<slot name="tools" />
</div>
Expand Down
4 changes: 1 addition & 3 deletions client/web/compose/src/components/ModuleFields/Editor/User.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,7 @@
{{ label }}
</span>

<hint
:text="hint"
/>
<c-hint :tooltip="hint" />

<slot name="tools" />
</div>
Expand Down
5 changes: 0 additions & 5 deletions client/web/compose/src/components/ModuleFields/Editor/base.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@
import multi from './multi'
import errors from '../errors'
import { compose, validator } from '@cortezaproject/corteza-js'
import Hint from 'corteza-webapp-compose/src/components/Common/Hint.vue'

export default {
components: {
Expand All @@ -25,10 +24,6 @@ export default {
// errors is used in the components that extends base
// eslint-disable-next-line vue/no-unused-components
errors,

// Hint is used in the components that extends base
// eslint-disable-next-line vue/no-unused-components
Hint,
},

props: {
Expand Down
Loading