-
Notifications
You must be signed in to change notification settings - Fork 365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Corteza studio UI personalization feature #1469
Conversation
eab0ec5
to
3e3e595
Compare
client/web/admin/src/components/Settings/UI/CUIBrandingEditor.vue
Outdated
Show resolved
Hide resolved
client/web/admin/src/components/Settings/UI/CUIBrandingEditor.vue
Outdated
Show resolved
Hide resolved
client/web/admin/src/components/Settings/UI/CUIBrandingEditor.vue
Outdated
Show resolved
Hide resolved
client/web/admin/src/components/Settings/UI/CUIBrandingEditor.vue
Outdated
Show resolved
Hide resolved
client/web/admin/src/components/Settings/UI/CUIBrandingEditor.vue
Outdated
Show resolved
Hide resolved
b912418
to
342910e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll need to do a bit of refactoring to clean it up and make it a bit friendlier to use. Also, please rebase so my changes don't show up in the diff (needles bloating).
Other then that, back-end stuff looking decent already
850455b
to
4c95f59
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some meta bits here and there
cb7bad8
to
1c21ea6
Compare
1e76f94
to
f08b964
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1+1 bits left; do take a quick look please
client/web/admin/src/components/Settings/UI/CUIBrandingEditor.vue
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks decent now!
What I'd consider is making the system service not just clear out the cache, but do the actual re-computation. It'll probably not change much, but could be a bit better.
f6c244d
to
060a599
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few notes but lgtm as before 👍
752e302
to
d776381
Compare
f7e5e20
to
b04c775
Compare
b04c775
to
ca4a10a
Compare
@katrinDY good observation I almost missed that..I've fixed that on my latest commit. |
Ref: #1267
Corteza Studio PR
This PR introduces a new feature that empowers users to personalize Corteza web applications according to their preferences using corteza main sass variables as branding parameters
[white, black, primary, secondary, success, warning, danger, light,extra-light, dark, tertiary, gray-200, body-bg]
. Something to note, however, when a sass variable for example$primary
is defined in the custom CSS editor, it will take precedence overbranding
variables.In case of any sass-related error, the default CSS which is compiled and minified
Bootstrap SASS, Bootstrap-Vue SASS and custom-webapp sass variables
will be returned.Additionally, SASS support has been integrated into the Corteza Server. However, users will need to install Dart-SASS locally or in the deployment environment, as detailed in the setup instructions provided here.
Major change introduced
Most of the SASS processing has been moved to the BE this includes; Bootstrap SASS, Bootstrap-Vue SASS, and custom webapp sass variables.
It is important to note that this change hasn't affected Custom CSS functionality
Branding Editor Screenshot
Video demo
corteza-studio.mov
Checklist when submitting a final (!draft) PR