Add a continuous modal navigation flow for all page block #1465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fajfa
requested changes
Oct 4, 2023
| @@ -126,10 +128,11 @@ export default { | |||
| clearRecordIDs: 'ui/clearRecordIDs', | |||
| }), | |||
|
|
|||
| loadRecord ({ recordID, recordPageID, values, refRecord }) { | |||
| loadRecord ({ recordID, recordPageID, values, refRecord, editMode }) { | |||
There was a problem hiding this comment.
i would call all of these just edit, since it will make sense from the context what it is, same for this.modalInEditModal, can be called edit
|
Discuss with Jože if these changes should be added before starting to implement What I've noticed:
- no 'x' btn when chart is magnified(zoomed in)
|
kelanik8
force-pushed
the
2023.3.x-feature-proper-modal-navigation-flow
branch
from
4f6e15c
to
b446973
Compare
Fajfa
approved these changes
Oct 17, 2023
kelanik8
force-pushed
the
2023.3.x-feature-proper-modal-navigation-flow
branch
from
b446973
to
fc37a73
Compare
|
One small thing: when mag. modal opens for a chart, the mag. icon is present first and then replaced with the x btn. Not sure if this is an issue. Discuss with Jože, please => update: this won't be addressed
|
kelanik8
force-pushed
the
2023.3.x-feature-proper-modal-navigation-flow
branch
from
fc37a73
to
eaa337c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following changes are implemented
TODO: Summary
Changes in the user interface:
TODO: Add screenshots, recordings or remove this section
Checklist when submitting a final (!draft) PR