-
Notifications
You must be signed in to change notification settings - Fork 365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix record selector, metric, chart values not refreshed when inline and bulk edit changes are applied to related records #1435
Fix record selector, metric, chart values not refreshed when inline and bulk edit changes are applied to related records #1435
Conversation
client/web/compose/src/components/ModuleFields/Viewer/Record.vue
Outdated
Show resolved
Hide resolved
client/web/compose/src/components/ModuleFields/Viewer/Record.vue
Outdated
Show resolved
Hide resolved
client/web/compose/src/components/PageBlocks/RecordListBase.vue
Outdated
Show resolved
Hide resolved
c8d0f16
to
3b62ef7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- All blocks that use fetchRecords (resolve), should be refreshed when a related record (with the same moduleID) is updated. If you could please check if there is any other page blocks that need this (record organizer does for example)
- For some reason the record list refreshes twice when using bulk record edit. Guessing the saving and the emited event triggers the refresh
client/web/compose/src/components/ModuleFields/Viewer/Record.vue
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems good to me, maybe some comments on the bits with more code, so we know why it's there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The double fetch still happens
b951369
to
bda42b5
Compare
bda42b5
to
c1b4c3d
Compare
c1b4c3d
to
4217a14
Compare
4217a14
to
4378189
Compare
4378189
to
573870b
Compare
Other pbs I think we should update after a change has been made in a RL: (Discuss with Jože how to proceed)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job, looks good to me
38e241c
to
4740e20
Compare
4740e20
to
348162f
Compare
Loading time is fine. My bad |
348162f
to
1ead204
Compare
…nd bulk edit changes are applied to related records
1ead204
to
35d455f
Compare
The following changes are implemented
TODO: Summary
Changes in the user interface:
TODO: Add screenshots, recordings or remove this section
Checklist when submitting a final (!draft) PR