Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(invert): Resetting the stack viewport properties should revert to the image's original invert setting #786

Merged
merged 1 commit into from
Sep 18, 2023

Conversation

jbocce
Copy link
Contributor

@jbocce jbocce commented Sep 18, 2023

Context

Fixes #764

Possibly addresses https://community.ohif.org/t/images-gets-inverted-when-resetting-zoom/1000

Changes & Results

Introduced an instance variable initialInvert to store the original invert for the image displayed.

Testing

Follow the instructions for #764.

Checklist

PR

  • My Pull Request title is descriptive, accurate and follows the
    semantic-release format and guidelines.

Code

Public Documentation Updates

  • The documentation page has been updated as necessary for any public API
    additions or removals.

Tested Environment

  • "OS: Windows 11
  • "Node version: 16.14.0
  • "Browser: Chrome 117.0.5938.89

@netlify
Copy link

netlify bot commented Sep 18, 2023

Deploy Preview for cornerstone-3d-docs ready!

Name Link
🔨 Latest commit e1e2b9e
🔍 Latest deploy log https://app.netlify.com/sites/cornerstone-3d-docs/deploys/6508605d5915190008ed391c
😎 Deploy Preview https://deploy-preview-786--cornerstone-3d-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jbocce jbocce requested a review from sedghi September 18, 2023 14:36
Copy link
Member

@sedghi sedghi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@sedghi sedghi merged commit 027a737 into cornerstonejs:main Sep 18, 2023
10 checks passed
@jbocce jbocce deleted the fix/invert branch September 18, 2023 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invert function not working some CR images
2 participants