Fix/expose api default mouse primary #622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cornerstone-3d-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
sedghi
approved these changes
May 23, 2023
iamiota
added a commit
to iamiota/cornerstone3D-beta
that referenced
this pull request
May 26, 2023
* 'main' of github.com:iamiota/cornerstone3D-beta: (59 commits) chore(release): publish [skip ci] fix(event): Interactions between double click and multi mouse button (cornerstonejs#616) chore(release): publish [skip ci] fix(windowLevel): should not double scale for window level (cornerstonejs#619) chore(release): publish [skip ci] fix(expose): api default mouse primary (cornerstonejs#622) chore(release): publish [skip ci] docs(typo): in imageLoader.md (cornerstonejs#629) chore(release): publish [skip ci] fix(husky): husky config (cornerstonejs#627) chore(release): publish [skip ci] feat(api): cornerstone3D (cornerstonejs#626) chore(release): publish [skip ci] feat(api)!: cornerstone3D version 1.0 (cornerstonejs#625) chore(release): publish [skip ci] feat(version1)!: publish version 1.0 (cornerstonejs#624) chore(release): publish [skip ci] fix(versioning): sync all versions (cornerstonejs#623) chore(release): publish [skip ci] fix(cpu): could not render if switched to cpu in the middle (cornerstonejs#615) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does not add new value to the package other than just expose an api to allow using a different default mouse primary.
Practically speaking more comparisons to "static" constants less flexible the api is.
The idea here is to expose an api that allows swapping mouse left and right with less friction to upper layers.
Context
Changes & Results
Testing
Checklist
PR
semantic-release format and guidelines.
Code
[] My code has been well-documented (function documentation, inline comments,
etc.)
[] I have run the
yarn build:update-apito update the API documentation, and havecommitted the changes to this PR. (Read more here https://www.cornerstonejs.org/docs/contribute/update-api)
Public Documentation Updates
additions or removals.
Tested Environment