fix(stackviewport): swap image row and column pixel spacing #561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit swaps image row and column pixel spacing of `StackViewport` in `RenderingEngine` while applying an epsilon comparison for float numbers comparison. It also adds Zoom tool to the `StackScrollToolMouseWheelTool_test.js` test script to scroll through stacks of images. Finally, it adjusts the test image data and updates the `yarn.lock` file to include codec-openjph 2.4.2 package.
✅ Deploy Preview for cornerstone-3d-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
a thought- should lines 1546 and 1548 also be swapped? |
|
you are right |
wayfarer3130
pushed a commit
that referenced
this pull request
Apr 18, 2023
This commit swaps image row and column pixel spacing of `StackViewport` in `RenderingEngine` while applying an epsilon comparison for float numbers comparison. It also adds Zoom tool to the `StackScrollToolMouseWheelTool_test.js` test script to scroll through stacks of images. Finally, it adjusts the test image data and updates the `yarn.lock` file to include codec-openjph 2.4.2 package.
RoyWiggins
added a commit
to RoyWiggins/cornerstone3D-beta
that referenced
this pull request
Apr 28, 2023
…onejs#561) This commit swaps image row and column pixel spacing of `StackViewport` in `RenderingEngine` while applying an epsilon comparison for float numbers comparison. It also adds Zoom tool to the `StackScrollToolMouseWheelTool_test.js` test script to scroll through stacks of images. Finally, it adjusts the test image data and updates the `yarn.lock` file to include codec-openjph 2.4.2 package.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit swaps image row and column pixel spacing of
StackViewportinRenderingEnginewhile applying an epsilon comparison for float numbers comparison. It also adds Zoom tool to theStackScrollToolMouseWheelTool_test.jstest script to scroll through stacks of images. Finally, it adjusts the test image data and updates theyarn.lockfile to include codec-openjph 2.4.2 package.fixes #548