Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(4d utility): getDataInTime from 4D data #460

Merged
merged 9 commits into from
Mar 6, 2023
Merged

feat(4d utility): getDataInTime from 4D data #460

merged 9 commits into from
Mar 6, 2023

Conversation

NeilMacPhee
Copy link
Contributor

Feature

  • using either a coordinate or segmentation Id, gets the scalar data for each voxel requested for a provided series of time points, or if left blank, for all time points
  • scalar data is returned as an array for a coordinate, and an array of arrays for a segmentation

@netlify
Copy link

netlify bot commented Mar 3, 2023 •
edited
Loading

✅ Deploy Preview for cornerstone-3d-docs ready!

Name Link
🔨 Latest commit 354fac2
🔍 Latest deploy log https://app.netlify.com/sites/cornerstone-3d-docs/deploys/64061dda3bc8e4000899fed1
😎 Deploy Preview https://deploy-preview-460--cornerstone-3d-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

javaDeveloperZeng pushed a commit to javaDeveloperZeng/cornerstone3D-beta that referenced this pull request Mar 6, 2023
@sedghi
feat: add rgba property to image object (cornerstonejs#460)
798ce3f
sedghi
sedghi requested changes Mar 6, 2023
View reviewed changes
Copy link
Member

@sedghi sedghi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see my comments

@NeilMacPhee
Copy link
Contributor Author

@sedghi Comments have been resolved

sedghi
sedghi approved these changes Mar 6, 2023
View reviewed changes
Copy link
Member

@sedghi sedghi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good thanks

@sedghi sedghi changed the title Feat: getDataInTime from 4D data feat(4d utility): getDataInTime from 4D data Mar 6, 2023
@sedghi sedghi merged commit 57bd947 into cornerstonejs:main Mar 6, 2023
@NeilMacPhee NeilMacPhee deleted the feat/getDataInTime branch March 6, 2023 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sedghi sedghi sedghi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NeilMacPhee @sedghi