Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(rendering): 16 bit texture support with flag #420

Merged
merged 2 commits into from
Mar 13, 2023
Merged

feat(rendering): 16 bit texture support with flag #420

merged 2 commits into from
Mar 13, 2023

Commits on Mar 13, 2023

  1. feat: added support for 16 bit textures. 

    Adds 16 bit texture support to cornerstone3D
  - CSWIL will decide on array type to match native storage format. In the case native format is unsigned int, if the scaling params are negative, prescale = true will return back a signed int.
  - Streaming Volume does require the array buffer type to be predetermined (targetBuffer must be specified). This is because all incoming slices need to adhere to one data type.
  - Block Height is set to 1 in the case norm16 is used due to this chromium bug: https://bugs.chromium.org/p/chromium/issues/detail?id=1408247. In the case preferSizeOverAccuracy is used block height for texture transfers can be calculated as usual.

TODO:
  - CSWIL needs to implement scaling logic. When a buffer type is not provided native is used (using signed versions of array buffers in the case scale is negative). When a buffer type is provided scaling will occur with possible over/underflows.

Co-authored-by: sedghi <ar.sedghi@gmail.com>
    @Ouwen @sedghi
    Ouwen and sedghi committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    0833bf6 View commit details
    Browse the repository at this point in the history

  2. config: turn default off

    @Ouwen
    Ouwen committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    52c9fca View commit details
    Browse the repository at this point in the history