Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(CobbAngle): Add CobbAngle tool #353

Merged
merged 2 commits into from
Jan 30, 2023
Merged

feat(CobbAngle): Add CobbAngle tool #353

merged 2 commits into from
Jan 30, 2023

Conversation

wayfarer3130
Copy link
Collaborator

Add a Cobb Angle implementation for CS3D.
Added to the examples that have AngleTool so that it can be compared.

@netlify
Copy link

netlify bot commented Jan 9, 2023

Deploy Preview for cornerstone-3d-docs ready!

Name Link
🔨 Latest commit 580b03a
🔍 Latest deploy log https://app.netlify.com/sites/cornerstone-3d-docs/deploys/63d7ed434bb017000995390c
😎 Deploy Preview https://deploy-preview-353--cornerstone-3d-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@sedghi sedghi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff

Two things

  1. Trying the example here, user should be able to drag and draw both lines. I can drag and draw the first one, but for some reason I can't drag and draw the second line. I only can click and draw second one. Maybe there is some limitation in our toolings and it is not this PR

  2. For ui/ux I would like to see some linking between the pairs, as it gets out of hand which one is paired with which one. This tool is often used in spine and you can guess what happens.
    image

I looked into other viewers, and there are some sort of linkings between them.

ClearCanvas
image

Meddream
image

Another one here
https://youtu.be/7XpYu-AjW0c?t=99

I honestly think doing something similar to meddream is like 10 mins of work (finding the middle of both lines and draw a dashed line). Can we have that please?

@sedghi sedghi changed the title feat:Add CobbAngle tool feat: Add CobbAngle tool Jan 13, 2023
@wayfarer3130 wayfarer3130 force-pushed the feat/cobb-angle branch 2 times, most recently from f7cc55f to dc38a45 Compare January 17, 2023 13:49
Copy link
Member

@sedghi sedghi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is certainly not the correct base for commits. It says 377 commits

image

@wayfarer3130 wayfarer3130 force-pushed the feat/cobb-angle branch 4 times, most recently from a9e0f78 to f44e681 Compare January 30, 2023 15:52
@sedghi sedghi changed the title feat: Add CobbAngle tool feat(CobbAngle): Add CobbAngle tool Jan 30, 2023
@sedghi sedghi merged commit b9bd701 into main Jan 30, 2023
@wayfarer3130 wayfarer3130 deleted the feat/cobb-angle branch January 31, 2023 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants