fix: colored images using rgba in CPU rendering #338

[Zaid-Safadi]

flip the useRGBA in StackViewport to true in the CPU path as discussed here: #338

[netlify]

✅ Deploy Preview for cornerstone-3d-docs ready!

Name	Link
🔨 Latest commit	e0c1e98
🔍 Latest deploy log	https://app.netlify.com/sites/cornerstone-3d-docs/deploys/63be2b03480ec900082e6a15
😎 Deploy Preview	https://deploy-preview-345--cornerstone-3d-docs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site settings.

[sedghi]

default is true, I don't think we need to specify here (please check wado).

[Zaid-Safadi]

default is true, I don't think we need to specify here (please check wado).

I think I see where you default it to true here

Isn't the StackViewport in cs3d? The comment says true only required for cs-legacy, sorry maybe I am not understanding the comment very well but it sounds like it should have worked if we set it to false in the StackViewport.

yeah, I can remove it from the options!

function createImage(imageId, pixelData, transferSyntax, options = {}) {
  // whether to use RGBA for color images, default true as cs-legacy uses RGBA
  // but we don't need RGBA in cs3d, and it's faster, and memory-efficient
  // in cs3d
  let useRGBA = true;

  if (options.useRGBA !== undefined) {
    useRGBA = options.useRGBA;
  }

[sedghi]

My comment was you don't need to have useRGBA:true in your changed files, since the default is true, you can just remove it

[Zaid-Safadi]

My comment was you don't need to have useRGBA:true in your changed files, since the default is true, you can just remove it

Lets keep it explicitly set to true so we are always sure it will work even if the wado library changes