Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bidirectional tool when short and long axis changes #309

Merged
merged 3 commits into from
Dec 1, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion common/reviews/api/core.api.md
Original file line number Diff line number Diff line change
Expand Up @@ -608,6 +608,9 @@ function getVolumeActorCorners(volumeActor: any): Array<Point3>;
// @public (undocumented)
function getVolumeViewportsContainingSameVolumes(targetViewport: IVolumeViewport, renderingEngineId?: string): Array<IVolumeViewport>;

// @public (undocumented)
function hasNaNValues(input: number[] | number): boolean;

// @public (undocumented)
interface ICache {
// (undocumented)
Expand Down Expand Up @@ -1967,7 +1970,8 @@ declare namespace utilities {
getViewportsWithImageURI,
calculateViewportsSpatialRegistration,
spatialRegistrationMetadataProvider,
getViewportImageCornersInWorld
getViewportImageCornersInWorld,
hasNaNValues
}
}
export { utilities }
Expand Down
8 changes: 5 additions & 3 deletions common/reviews/api/tools.api.md
Original file line number Diff line number Diff line change
Expand Up @@ -503,8 +503,12 @@ export class BidirectionalTool extends AnnotationTool {
hasMoved?: boolean;
} | null;
// (undocumented)
_getSignedAngle: (vector1: any, vector2: any) => number;
// (undocumented)
_getTextLines: (data: any, targetId: any) => string[];
// (undocumented)
_handleDragModify: (evt: any) => void;
// (undocumented)
handleSelectedCallback: (evt: EventTypes_2.MouseDownEventType, annotation: BidirectionalAnnotation, handle: ToolHandle, interactionType?: string) => void;
// (undocumented)
isDrawing: boolean;
Expand All @@ -521,11 +525,9 @@ export class BidirectionalTool extends AnnotationTool {
// (undocumented)
_mouseDragModifyCallback: (evt: MouseDragEventType) => void;
// (undocumented)
_mouseDragModifyHandle: (evt: any) => void;
// (undocumented)
_mouseUpCallback: (evt: EventTypes_2.MouseUpEventType | EventTypes_2.MouseClickEventType) => void;
// (undocumented)
_movingLongAxisWouldPutItThroughShortAxis: (proposedFirstLineSegment: any, secondLineSegment: any) => boolean;
_movingLongAxisWouldPutItThroughShortAxis: (firstLineSegment: any, secondLineSegment: any) => boolean;
// (undocumented)
preventHandleOutsideImage: boolean;
// (undocumented)
Expand Down
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,10 @@
"yarn": ">=1.19.1"
},
"scripts": {
"api-check": "lerna run --concurrency 1 api-check ",
"api-check": "lerna run api-check ",
"build": "lerna run build --stream",
"build:umd": "lerna run build:umd --stream",
"build:update-api": "lerna run --concurrency 1 build:update-api",
"build:update-api": "lerna run build:update-api",
"example": "node ./utils/ExampleRunner/example-runner-cli.js",
"all-examples": "node ./utils/ExampleRunner/build-all-examples-cli.js --fromRoot",
"build-all-examples": "node ./utils/ExampleRunner/build-all-examples-cli.js --build --fromRoot",
Expand Down
2 changes: 2 additions & 0 deletions packages/core/src/utilities/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ import getViewportsWithImageURI from './getViewportsWithImageURI';
import calculateViewportsSpatialRegistration from './calculateViewportsSpatialRegistration';
import spatialRegistrationMetadataProvider from './spatialRegistrationMetadataProvider';
import getViewportImageCornersInWorld from './getViewportImageCornersInWorld';
import hasNaNValues from './hasNaNValues';

// name spaces
import * as planar from './planar';
Expand Down Expand Up @@ -70,4 +71,5 @@ export {
calculateViewportsSpatialRegistration,
spatialRegistrationMetadataProvider,
getViewportImageCornersInWorld,
hasNaNValues,
};
Loading