Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add reference lines tool #292

Merged
merged 10 commits into from
Nov 11, 2022
Merged

feat: add reference lines tool #292

merged 10 commits into from
Nov 11, 2022

Conversation

sedghi
Copy link
Member

@sedghi sedghi commented Nov 11, 2022

@netlify
Copy link

netlify bot commented Nov 11, 2022

Deploy Preview for cornerstone-3d-docs ready!

Name Link
🔨 Latest commit c0419a7
🔍 Latest deploy log https://app.netlify.com/sites/cornerstone-3d-docs/deploys/636ecccb7b10f6000874ff4e
😎 Deploy Preview https://deploy-preview-292--cornerstone-3d-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sedghi sedghi requested a review from swederik November 11, 2022 01:52
Copy link
Member

@swederik swederik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

common/reviews/api/tools.api.md Outdated Show resolved Hide resolved
packages/tools/src/tools/ReferenceLinesTool.ts Outdated Show resolved Hide resolved
@sedghi sedghi changed the title Feat/reference lines feat: add reference lines tool Nov 11, 2022
@sedghi sedghi merged commit c56df91 into main Nov 11, 2022
NeilMacPhee pushed a commit to NeilMacPhee/cornerstone3D-beta that referenced this pull request Nov 16, 2022
* initial commit for setting up

* feat: add annotation display Tool

* fix: reference lines render for parallel viewports

* remove window assignment

* apply review

* remove stream for lerna

* fix: reference lines for edge cases

* fix types

* fix naming

* try to fix the api extractor
NeilMacPhee pushed a commit to NeilMacPhee/cornerstone3D-beta that referenced this pull request Nov 22, 2022
* initial commit for setting up

* feat: add annotation display Tool

* fix: reference lines render for parallel viewports

* remove window assignment

* apply review

* remove stream for lerna

* fix: reference lines for edge cases

* fix types

* fix naming

* try to fix the api extractor
NeilMacPhee pushed a commit to NeilMacPhee/cornerstone3D-beta that referenced this pull request Nov 22, 2022
* initial commit for setting up

* feat: add annotation display Tool

* fix: reference lines render for parallel viewports

* remove window assignment

* apply review

* remove stream for lerna

* fix: reference lines for edge cases

* fix types

* fix naming

* try to fix the api extractor
wayfarer3130 pushed a commit that referenced this pull request Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants