Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue when getting an index that equals 0. #265

Merged
merged 2 commits into from
Oct 27, 2022
Merged

Fix issue when getting an index that equals 0. #265

merged 2 commits into from
Oct 27, 2022

Commits on Oct 26, 2022

  1. Fix issue when getting an index that equals 0. 

    When using this method while being on the first image, the index returns 0, and this method would return `undefined`.
This is unwanted since the first image obviously has a 0 index which is usable.
My fix simply consists of ensuring the returned value is a number (see https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/isNaN).
    @gabriellebaudy
    gabriellebaudy authored Oct 26, 2022
    Configuration menu
    Copy the full SHA
    9c93a0e View commit details
    Browse the repository at this point in the history

  2. Update VolumeViewport.ts

    @gabriellebaudy
    gabriellebaudy authored Oct 26, 2022
    Configuration menu
    Copy the full SHA
    6f2b5c4 View commit details
    Browse the repository at this point in the history