fix: viewRight was calculated wrong for tools

packages/core/examples/stackEvents/index.ts

@@ -189,12 +189,10 @@ addButtonToToolbar({
     const newParallelScale = parallelScale * randomModifier;
 
     // Move the camera in plane by some random number
-    let viewRight = vec3.create(); // Get the X direction of the viewport
+    const viewRight = vec3.create(); // Get the X direction of the viewport
 
     vec3.cross(viewRight, <vec3>viewUp, <vec3>viewPlaneNormal);
 
-    viewRight = [-viewRight[0], -viewRight[1], -viewRight[2]];
-
     const randomPanX = 50 * (2.0 * Math.random() - 1);
     const randomPanY = 50 * (2.0 * Math.random() - 1);
 

packages/core/src/RenderingEngine/Viewport.ts

@@ -1038,12 +1038,10 @@ class Viewport implements IViewport {
     const viewUpCorners = this._getCorners(bounds);
     const viewRightCorners = this._getCorners(bounds);
 
-    let viewRight = vec3.create();
+    const viewRight = vec3.create();
 
     vec3.cross(viewRight, viewUp, viewPlaneNormal);
 
-    viewRight = [-viewRight[0], -viewRight[1], -viewRight[2]];
-
     let transform = vtkMatrixBuilder
       .buildFromDegree()
       .identity()
@@ -1067,7 +1065,10 @@ class Viewport implements IViewport {
     transform = vtkMatrixBuilder
       .buildFromDegree()
       .identity()
-      .rotateFromDirections(viewRight, [1, 0, 0]);
+      .rotateFromDirections(
+        [viewRight[0], viewRight[1], viewRight[2]],
+        [1, 0, 0]
+      );
 
     viewRightCorners.forEach((pt) => transform.apply(pt));
 

packages/tools/src/utilities/math/polyline/getSubPixelSpacingAndXYDirections.ts

@@ -43,12 +43,10 @@ const getSubPixelSpacingAndXYDirections = (
     const jVector = direction.slice(3, 6) as Types.Point3;
     const kVector = direction.slice(6, 9) as Types.Point3;
 
-    let viewRight = vec3.create(); // Get the X direction of the viewport
+    const viewRight = vec3.create(); // Get the X direction of the viewport
 
     vec3.cross(viewRight, <vec3>viewUp, <vec3>viewPlaneNormal);
 
-    viewRight = [-viewRight[0], -viewRight[1], -viewRight[2]];
-
     const absViewRightDotI = Math.abs(vec3.dot(viewRight, iVector));
     const absViewRightDotJ = Math.abs(vec3.dot(viewRight, jVector));
     const absViewRightDotK = Math.abs(vec3.dot(viewRight, kVector));

packages/tools/src/utilities/planar/getWorldWidthAndHeightFromCorners.ts

@@ -21,12 +21,10 @@ export default function getWorldWidthAndHeightFromCorners(
   topLeftWorld: Types.Point3,
   bottomRightWorld: Types.Point3
 ): { worldWidth: number; worldHeight: number } {
-  let viewRight = vec3.create();
+  const viewRight = vec3.create();
 
   vec3.cross(viewRight, <vec3>viewUp, <vec3>viewPlaneNormal);
 
-  viewRight = [-viewRight[0], -viewRight[1], -viewRight[2]];
-
   const pos1 = vec3.fromValues(...topLeftWorld);
   const pos2 = vec3.fromValues(...bottomRightWorld);
 

packages/tools/src/utilities/planar/getWorldWidthAndHeightFromTwoPoints.ts

@@ -21,12 +21,10 @@ export default function getWorldWidthAndHeightFromTwoPoints(
   worldPos1: Types.Point3,
   worldPos2: Types.Point3
 ): { worldWidth: number; worldHeight: number } {
-  let viewRight = vec3.create();
+  const viewRight = vec3.create();
 
   vec3.cross(viewRight, <vec3>viewUp, <vec3>viewPlaneNormal);
 
-  viewRight = [-viewRight[0], -viewRight[1], -viewRight[2]];
-
   const pos1 = vec3.fromValues(...worldPos1);
   const pos2 = vec3.fromValues(...worldPos2);
 

packages/tools/src/utilities/pointInSurroundingSphereCallback.ts

@@ -152,10 +152,9 @@ function _computeBoundsIJKWithCamera(
     camera.viewPlaneNormal[1],
     camera.viewPlaneNormal[2]
   );
-  let viewRight = vec3.create();
+  const viewRight = vec3.create();
 
   vec3.cross(viewRight, viewUp, viewPlaneNormal);
-  viewRight = [-viewRight[0], -viewRight[1], -viewRight[2]];
 
   // we need to find the bounding box of the sphere in the image, e.g., the
   // topLeftWorld and bottomRightWorld points of the bounding box.

utils/demo/helpers/camera/getRandomlyTranslatedAndZoomedCameraProperties.js

@@ -16,8 +16,6 @@ export default function getRandomlyTranslatedAndZoomedCameraProperties(
 
   vec3.cross(viewRight, viewUp, viewPlaneNormal);
 
-  viewRight = [-viewRight[0], -viewRight[1], -viewRight[2]];
-
   const randomPanX = maxTranslateInMM * (2.0 * Math.random() - 1);
   const randomPanY = maxTranslateInMM * (2.0 * Math.random() - 1);