feat(rendering): 16 bit texture support with flag #420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cornerstone-3d-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Ouwen
force-pushed
the
gradienthealth/16-bit-texture-support
branch
3 times, most recently
from
f550c36
to
357970b
Compare
|
pending vtk 26.4.0 |
Ouwen
force-pushed
the
gradienthealth/16-bit-texture-support
branch
from
357970b
to
4c86d35
Compare
|
@sedghi ready for review |
Ouwen
commented
Feb 7, 2023
Ouwen
force-pushed
the
gradienthealth/16-bit-texture-support
branch
from
4c86d35
to
c9df864
Compare
sedghi
reviewed
Feb 13, 2023
sedghi
reviewed
Feb 13, 2023
packages/streaming-image-volume-loader/src/helpers/scaleArray.ts
Outdated
Show resolved
Hide resolved
sedghi
reviewed
Feb 13, 2023
packages/streaming-image-volume-loader/src/StreamingImageVolume.ts
Outdated
Show resolved
Hide resolved
packages/streaming-image-volume-loader/src/cornerstoneStreamingImageVolumeLoader.ts
Outdated
Show resolved
Hide resolved
packages/core/src/index.ts
Outdated
Comment on lines
65
to
72
| // init | ||
| init, | ||
| hasNorm16TextureSupport, | ||
| hasActiveWebGLContext, | ||
| isCornerstoneInitialized, | ||
| // configs | ||
| getConfiguration, | ||
| setPreferSizeOverAccuracy, |
There was a problem hiding this comment.
These are getting out of hand, can we put them under the configUtils?
packages/core/src/RenderingEngine/vtkClasses/vtkStreamingOpenGLTexture.js
Outdated
Show resolved
Hide resolved
Ouwen
force-pushed
the
gradienthealth/16-bit-texture-support
branch
from
c9df864
to
03d8490
Compare
Adds 16 bit texture support to cornerstone3D - CSWIL will decide on array type to match native storage format. In the case native format is unsigned int, if the scaling params are negative, prescale = true will return back a signed int. - Streaming Volume does require the array buffer type to be predetermined (targetBuffer must be specified). This is because all incoming slices need to adhere to one data type. - Block Height is set to 1 in the case norm16 is used due to this chromium bug: https://bugs.chromium.org/p/chromium/issues/detail?id=1408247. In the case preferSizeOverAccuracy is used block height for texture transfers can be calculated as usual. TODO: - CSWIL needs to implement scaling logic. When a buffer type is not provided native is used (using signed versions of array buffers in the case scale is negative). When a buffer type is provided scaling will occur with possible over/underflows. Co-authored-by: sedghi <ar.sedghi@gmail.com>
Ouwen
force-pushed
the
gradienthealth/16-bit-texture-support
branch
from
c0fe82d
to
0833bf6
Compare
|
@sedghi the above is ready for review with previous comments addressed. Let me know what you think! |
sedghi
changed the title
sedghi
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds 16 bit texture support to cornerstone3D
External PR (cornerstonejs/cornerstoneWADOImageLoader#509):