Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show terminal warning only when user did not enter arguments. #1120

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

johnrom
Copy link

@johnrom johnrom commented Apr 1, 2024

closes #1068

(doesn't fix the underlying terminal check, but limits the issue to users who didn't enter any nvm command)

Only check terminal when there are no arguments, because it's possible the user clicked the .exe. If there are arguments, assume the user knows what they're doing. Add some launch tasks in .vscode to demonstrate the difference. The warning now indicates that if you are in an unsupported terminal, to try running nvm help instead.

Feel free to remove .vscode/launch.json if you do not use VS Code. I used it to create an example of:

  • Launching nvm without commands in debug console -- opens warning indicating nvm can only be run in a terminal
  • Launching nvm in external console (like command prompt) -- prints normal help message in terminal
  • Launching nvm version in debug console -- works normally

…e the user clicked the `.exe`. If there are arguments, assume the user knows what they're doing. Add some launch tasks in `.vscode` to demonstrate the difference.
Copy link

github-actions bot commented May 2, 2024

This PR is stale because it has been open 45 days with no activity.

@github-actions github-actions bot added Stale Stale and removed Stale Stale labels May 2, 2024
Copy link

github-actions bot commented Jun 3, 2024

This PR is stale because it has been open 45 days with no activity.

@github-actions github-actions bot added the Stale Stale label Jun 3, 2024
@mpociot
Copy link

mpociot commented Jun 10, 2024

Would be great if this could get reviewed and merged 👍

@github-actions github-actions bot removed the Stale Stale label Jun 11, 2024
Copy link

This PR is stale because it has been open 45 days with no activity.

@github-actions github-actions bot added the Stale Stale label Jul 11, 2024
@EmilSoleymani
Copy link

Can this be reviewed/merged? Currently blocking my Jenkins2 pipelines

@github-actions github-actions bot removed the Stale Stale label Jul 25, 2024
Copy link

This PR is stale because it has been open 45 days with no activity.

@github-actions github-actions bot added the Stale Stale label Aug 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Stale Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Issue]: nvm-update.exe: NVM for Windows should be run from a terminal such as CMD or PowerShell
3 participants