Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install: Don't require the network by default #1335

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Commits on Nov 9, 2023

  1. install: Don't require the network by default

    The `Wants=network-online.target` predates the osmet work which enabled
    the now default fully offline install flow.
    
    It also predates the addition of fetch retries. So even in an online
    flow, now that we retry HTTP requests indefinitely, we don't really
    need this.
    
    Let's follow best practices and stop pulling in `network-online.target`.
    
    We still need to keep pulling in `NetworkManager.service`
    though. It's enabled by default in `multi-user.target` but not
    `coreos-installer-post.target` (which is what we boot to in an automated
    install).
    
    NetworkManager is capable of handling offline environments just fine and
    won't block the install just because a connection isn't available (yet
    or ever).
    
    Related: coreos/fedora-coreos-config#1088
    Related: coreos#565 (comment)
    Related: https://www.freedesktop.org/wiki/Software/systemd/NetworkTarget/
    Closes: https://github.com/coreos/coreos-installer/issues/1334
    jlebon committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    2bf8bbe View commit details
    Browse the repository at this point in the history
  2. install: Drop reference to systemd-resolved.service

    We don't need this anymore now that we do retry HTTP fetches.
    jlebon committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    e6bc574 View commit details
    Browse the repository at this point in the history