Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename to cordova-webintent for consistency; bump version to 2.0.0 #18

Merged
merged 1 commit into from
May 30, 2019

Conversation

alalamav
Copy link
Collaborator

  • Now that Cordova favors package.json over config.xml for plugin versioning, renaming the plugin and changing the id to cordova-webintent ensures that there are no redundant plugin declarations (cordova-webintent, com.borismus.webintent). Additionally, the plugin ID change prevents Cordova from fetching the com.borismus.webintent plugin published on npm.
  • Bumping the version to 2.0.0, since the rename is not backwards compatible.

@alalamav alalamav requested review from jab and chrisekelley May 30, 2019 16:49
@alalamav alalamav self-assigned this May 30, 2019
Copy link
Collaborator

@chrisekelley chrisekelley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much, looks good!

@chrisekelley chrisekelley merged commit 81788d6 into master May 30, 2019
@chrisekelley chrisekelley deleted the alalama-v2.0.0 branch May 30, 2019 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants