Do not overwrite identical files

[kefirbandi]

If _render_allowed identifies identical source and target, then only returns True if the path refers to a directory, not a file.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.33%. Comparing base (70aa69f) to head (f7d261e).
Report is 16 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1576      +/-   ##
==========================================
+ Coverage   97.29%   97.33%   +0.04%     
==========================================
  Files          48       48              
  Lines        4621     4728     +107     
==========================================
+ Hits         4496     4602     +106     
- Misses        125      126       +1     

Flag	Coverage Δ
unittests	97.33% <100.00%> (+0.04%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[sisp]

Just a test is missing (see #1092 (reply in thread)).

Resolves #1092.

[yajo]

Cool! Do you know how to add the test then?

[kefirbandi]

Cool! Do you know how to add the test then?

I would use the testcase: test_skip_if_exists as an example, and write something along the lines of:

def test_timestamp_identical(tmp_path: Path) -> None:
    copier.run_copy(str(Path("tests", "demo_skip_dst")), tmp_path)
    modification_time_before = ...
    sleep(2)
    copier.run_copy(str(Path("tests", "demo_skip_dst")), tmp_path)
    modification_time_after = ...

    assert modification_time_before == modification_time_after
   

Does it make sense?

[yajo]

Ok El lun, 8 abr 2024, 3:17, Andras Gefferth ***@***.***> escribió:

…

Cool! Do you know how to add the test then? I would use the testcase: test_skip_if_exists <https://github.com/copier-org/copier/blob/master/tests/test_copy.py#L285> as an example, and write something along the lines of: def test_timestamp_identical(tmp_path: Path) -> None: copier.run_copy(str(Path("tests", "demo_skip_dst")), tmp_path) modification_time_before = ... sleep(2) copier.run_copy(str(Path("tests", "demo_skip_dst")), tmp_path) modification_time_after = ... assert modification_time_before == modification_time_after Does it make sense? — Reply to this email directly, view it on GitHub <#1576 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAHNXDLIVFV47LTXYJAHL3TY4H42NAVCNFSM6AAAAABF24WGXCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANBRG42DKNRRHE> . You are receiving this because you commented.Message ID: ***@***.***>

[sisp]

Just a minor linter error. LGTM otherwise! 🎉