Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix where onReady not firing because IOS doesn't load past metadata with autoplay off #1805

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kozr
Copy link

@kozr kozr commented Apr 19, 2024

Bug Fix

There is a problem where the onReady function in react-player isn't being called on IOS when autoPlay is false. This is because IOS stops loading past metadata when autoplay is off (readyState remains at 1).

Also get rid of line 83 which seems like a duplicate?

Stackoverflow
GitHub Livepeer PR

@kozr
Copy link
Author

kozr commented Apr 19, 2024

@luwes

@luwes
Copy link
Collaborator

luwes commented Apr 20, 2024

thanks for the contribution but this needs some more investigation. If preload=none even loadedmetadata would not fire.
I'll have to dig in when onReady is called in all players.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants