Skip to content
This repository has been archived by the owner on Nov 27, 2023. It is now read-only.

fix: issue #91, missing steps on readme #93

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

HectorMRC
Copy link

@HectorMRC HectorMRC commented Apr 2, 2022

Step missing on 'build and install' step from mini-tutorial + no 2nd step on 'enabling name resolution on the default Podman network'.

@HectorMRC
Copy link
Author

/assign @mheon

@mheon
Copy link
Member

mheon commented Apr 4, 2022

LGTM

@mheon
Copy link
Member

mheon commented Apr 4, 2022

Per CI, your commit has whitespace errors that can be viewed by git show --check bce593bba452dde45c272e3af22b294ad7f14d7b, and requires a signoff (git commit --amend -s should add one).

@mheon
Copy link
Member

mheon commented Apr 4, 2022

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 4, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HectorMRC, mheon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: HectorMRC <thehector1593@gmail.com>
@HectorMRC
Copy link
Author

@mheon all validation errors have been resolved, Tide's check is pending for lgtm label

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants