mac helper binaries: add default brew libexec path #1523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vrothberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 similar comment
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vrothberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
vrothberg
force-pushed
the
mac-helpers-dir
branch
from
2bc1130
to
50b8431
Compare
|
@ashley-cui @Luap99 @baude PTAL |
Luap99
reviewed
Jun 26, 2023
ashley-cui
reviewed
Jun 26, 2023
After installing podman via brew, I expected a locally compiled one to work as well. But it failed as it could not find gvproxy. It turns out that brew installs it at /opt/homebrew/opt/podman/libexec/podman/gvproxy, so I want the directory to be part of the default look-up paths. Same applies to the `/usr/local/opt` paths used on Intel Macs. Also rearrange the order a bit. Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
vrothberg
force-pushed
the
mac-helpers-dir
branch
from
50b8431
to
12fdcb0
Compare
|
Updated |
|
/lgtm |
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After installing podman via brew, I expected a locally compiled one to work as well. But it failed as it could not find gvproxy. It turns out that brew installs it at /opt/homebrew/opt/podman/libexec/podman/gvproxy, so I want the directory to be part of the default look-up paths.