Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update buildah-build 'platform' option compatibility notes #3580

Merged
merged 2 commits into from
Oct 11, 2021
Merged

docs: update buildah-build 'platform' option compatibility notes #3580

merged 2 commits into from
Oct 11, 2021

Conversation

jayaddison
Copy link
Contributor

What type of PR is this?

/kind documentation

What this PR does / why we need it:

Updates the buildah-build documentation to clarify that the platform option conflicts with the os/arch/variant options.

How to verify it

Run a buildah v1.19+ container build with both platform and arch options set (ref: redhat-actions/buildah-build#75)

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

Does this PR introduce a user-facing change?

None

@openshift-ci openshift-ci bot added the kind/documentation Categorizes issue or PR as related to documentation. label Oct 9, 2021
@rhatdan
Copy link
Member

rhatdan commented Oct 10, 2021

Thanks @jayaddison.
You must sign your commits.

git commit -a --amend -s
git push --force

LGTM

Signed-off-by: James Addison <jay@jp-hosting.net>
@jayaddison
Copy link
Contributor Author

Commit signed; thanks @rhatdan

…ty notes

Signed-off-by: James Addison <jay@jp-hosting.net>
Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/hold

Restarted the flaked job.

@vrothberg
Copy link
Member

/hold cancel

@TomSweeneyRedHat
Copy link
Member

/lgtm
/approve
Thanks @jayaddison !

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 11, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jayaddison, TomSweeneyRedHat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 47c78dd into containers:main Oct 11, 2021
@jayaddison
Copy link
Contributor Author

Thanks @vrothberg @TomSweeneyRedHat!

@jayaddison jayaddison deleted the docs/buildah-build-platform branch October 11, 2021 17:33
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved kind/documentation Categorizes issue or PR as related to documentation. lgtm locked - please file new issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants