cli: wipe_ostree in spawn_blocking #779
Merged
+8
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omertuc
force-pushed
the
spawn_blocking
branch
2 times, most recently
from
efb0d36
to
215e099
Compare
cgwalters
reviewed
Sep 6, 2024
omertuc
force-pushed
the
spawn_blocking
branch
from
215e099
to
ae54070
Compare
An async fn shouldn't block the thread, but write_deployments is a blocking heavy filesystem operation. Using tokio::task::spawn_blocking to avoid blocking async threads. Solves containers#778 Signed-off-by: Omer Tuchfeld <omer@tuchfeld.dev>
omertuc
force-pushed
the
spawn_blocking
branch
from
ae54070
to
0eb8d3b
Compare
cgwalters
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #778