Change source from ilab wrapper #599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enriquebelarte
requested review from
MichaelClifford,
rhatdan,
sallyom,
lmilbaum,
cgwalters and
Gregory-Pereira
as code owners
Signed-off-by: Enrique Belarte Luque <ebelarte@redhat.com>
enriquebelarte
force-pushed
the
change-ilab-wrapper
branch
from
b4b5ece
to
528ae44
Compare
Gregory-Pereira
requested changes
Jun 21, 2024
| cp /run/.input/ilab /usr/local/bin/ilab | ||
| /etc/containers/storage.conf | ||
|
|
||
| COPY ../ilab-wrapper/ilab /usr/local/bin/ilab |
Gregory-Pereira
approved these changes
Jun 22, 2024
|
Ah darn we are going to need to revert this: Error: building at STEP "COPY ../ilab-wrapper/ilab /usr/local/bin/ilab": checking on sources under "/mnt/disk/ai-lab-recipes/training/nvidia-bootc": possible escaping context directory error: copier: stat: "/ilab-wrapper/ilab": no such file or directory |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copying the
ilabscript from the image mount as it is done now breaks Konflux CI. If I'm not missing something we could get the same existing script from upper level and also that would ease CI tasks./cc @rhatdan @fabiendupont @Gregory-Pereira