Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move bootc builder (dtk) to common #586

Merged
merged 2 commits into from
Jun 20, 2024
Merged

Conversation

Gregory-Pereira
Copy link
Collaborator

Relates to: #585 (comment)
Depends on rebase and merge of #585
/cc @fabiendupont @enriquebelarte

@Gregory-Pereira Gregory-Pereira changed the title move bootc builder to common move bootc builder (dtk) to common Jun 19, 2024
@Gregory-Pereira
Copy link
Collaborator Author

CI still needs to be implemented / updated for generic builder but Ill wait for parent PR to rebase in Jasons changes

@fabiendupont
Copy link
Contributor

Why not call the image driver-toolkit?

@Gregory-Pereira
Copy link
Collaborator Author

I was keeping it as it was for consistency but I think since were already moving this we may as well name it in a more friendly way.

@Gregory-Pereira Gregory-Pereira force-pushed the nvidia-builder-to-builer branch 3 times, most recently from dbb4405 to b21c2b0 Compare June 19, 2024 21:24
@Gregory-Pereira Gregory-Pereira marked this pull request as ready for review June 19, 2024 21:28
Signed-off-by: greg pereira <grpereir@redhat.com>
Signed-off-by: greg pereira <grpereir@redhat.com>
Copy link
Contributor

@fabiendupont fabiendupont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Collaborator

@enriquebelarte enriquebelarte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@Gregory-Pereira Gregory-Pereira merged commit 13b721d into main Jun 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants