Make growfs conditional #572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enriquebelarte
requested review from
MichaelClifford,
rhatdan,
sallyom,
lmilbaum,
cgwalters and
Gregory-Pereira
as code owners
growfs is created by Makefile and CI does not use it. Also if I'm not misktaken growfs is only used for disk images creation. By changing this, growfs file will only be created when Makefile is runningso CI pipelines can build the Containerfile and growfs can be also used when needed. Signed-off-by: Enrique Belarte Luque <ebelarte@redhat.com>
enriquebelarte
force-pushed
the
conditional-growfs
branch
from
a6c9448
to
3b7a78b
Compare
|
/LGTM @Gregory-Pereira thoughts? |
Closed
|
This is wrong. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
growfs is created by Makefile and CI does not use it. Also if I'm not misktaken growfs is only used for disk images creation. By changing this, growfs files will only be created when
Makefileis run, so CI build pipelines can use theContainerfileand growfs can be also used when needed runningmake.If change is accepted I'll submit additional PRs for amd and intel.