Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix invalid instructions in README.md #510

Merged
merged 1 commit into from
May 27, 2024
Merged

Fix invalid instructions in README.md #510

merged 1 commit into from
May 27, 2024

Conversation

gcolman
Copy link
Contributor

@gcolman gcolman commented May 23, 2024

Fixed two instructions in the README that stop the examples working.

  1. the instruction to make model pointed to etr-resnet-50 rather than the etr-resnet-101 that the instructions use. 2) The client container start had a /detecion in the model address where it should not have.

Gregory-Pereira
Gregory-Pereira approved these changes May 23, 2024
View reviewed changes
Copy link
Collaborator

@Gregory-Pereira Gregory-Pereira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The README.mds sometimes get out of date because we usually maintain the Makefiles as the source of truth. Both changes look good, thanks!

@Gregory-Pereira
Copy link
Collaborator

Please make sure to just signoff your commit to pass DCO.

@rhatdan
Copy link
Member

rhatdan commented May 25, 2024

LGTM
git commit -a --amend -s
git push --force

And then we can merge.

@gcolman
Fix invalid instructions in README.md
2573e7d 
Fixed two instructions in the README.
1) the instruction to make model pointed to etr-resnet-50 rather than the etr-resnet-101 that the instructions use.
2) The client container start had a /detecion in the model address where it should not have.
added signoff

Signed-off-by: Graeme Colman <gcolman@redhat.com>
@rhatdan rhatdan merged commit 5fd2597 into containers:main May 27, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gregory-Pereira Gregory-Pereira Gregory-Pereira approved these changes

@MichaelClifford MichaelClifford Awaiting requested review from MichaelClifford MichaelClifford is a code owner

@rhatdan rhatdan Awaiting requested review from rhatdan rhatdan is a code owner

@sallyom sallyom Awaiting requested review from sallyom sallyom is a code owner

@lmilbaum lmilbaum Awaiting requested review from lmilbaum lmilbaum is a code owner

@cgwalters cgwalters Awaiting requested review from cgwalters cgwalters is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gcolman @Gregory-Pereira @rhatdan