-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add model service check #41
Conversation
This PR does not make any changes to the model service. However, it looks like you may have added the environment variables incorrectly. This model service is the same as the playground, so it should be deployed the same way.
|
Added an additional commit that incudes the same check in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@MichaelClifford can you rebase it so that it includes my latest patch |
1937c47
to
d9711ae
Compare
@jeffmaury rebased 😄 |
Another suggestion: would also be good to have the time spent to get the model service available at the end of loop |
@jeffmaury How does this look? |
535324b
to
0c1e548
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works fine for me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
merging as it has been approved by everyone. Thanks @MichaelClifford!! |
This PR adds a check to the application to make sure the model service is running before proceeding. Once this PR is approved, we can roll out this same approach on the rest of the AI applications.