Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

model container builder #398

Merged
merged 4 commits into from
Apr 30, 2024
Merged

model container builder #398

merged 4 commits into from
Apr 30, 2024

Conversation

kwozyman
Copy link
Collaborator

No description provided.

Signed-off-by: Costin Gamenț <cgament@redhat.com>
Signed-off-by: Costin Gamenț <cgament@redhat.com>
Signed-off-by: Costin Gamenț <cgament@redhat.com>
Copy link
Collaborator

@Gregory-Pereira Gregory-Pereira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm, but 1 required change and 1 optional change

training/model/Makefile Outdated Show resolved Hide resolved
training/model/Makefile Show resolved Hide resolved
Co-authored-by: Gregory Pereira <grpereir@redhat.com>
Signed-off-by: Costin Gamenț <cgament@redhat.com>
Copy link
Collaborator

@Gregory-Pereira Gregory-Pereira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Required change fixed, marking this as approved. If you want to include the optional change feel free.

@kwozyman kwozyman merged commit b368f52 into main Apr 30, 2024
1 check passed
@kwozyman kwozyman deleted the magma branch April 30, 2024 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants