-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor instructlab training images to use make targets #387
refactor instructlab training images to use make targets #387
Conversation
changes: 1) add label and arch options to builds 2) extending workflow to intel-bootc, amd-bootc, and better workflow naming Signed-off-by: greg pereira <grpereir@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR includes multiple changes which makes it hard to review. How challenging it is to break it into smaller PRs?
The FYI I have tested builds and each of these aside from the |
c20e6f0
to
814cad7
Compare
I have dropped the slack notifications pieces |
e9bcd41
to
cee46cc
Compare
Signed-off-by: greg pereira <grpereir@redhat.com>
cee46cc
to
2167fb4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Addresses: #364
changes:
intel-bootc
,amd-bootc
, and better workflow naming/cc @sallyom @rhatdan @lmilbaum