Consistently name llamacpp-python #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All through the code this is sometimes labeled llamacpp_python Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
rhatdan
requested review from
MichaelClifford,
sallyom,
lmilbaum and
cgwalters
as code owners
Closed
|
I am fine with going the other way and labeling them all as llamacpp_python But we need to be consistent. Currently in quay.io/ai-lab we have one of each. |
|
Either is fine by me. Once this gets merged I will scrub the other set from |
Gregory-Pereira
approved these changes
Apr 19, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All through the code this is sometimes labeled llamacpp_python