Replace playground with model_servers #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
MichaelClifford
force-pushed
the
reorganize
branch
from
9b54eb4
to
2b32449
Compare
|
Thanks @lstocchi added. |
Signed-off-by: Michael Clifford <mcliffor@redhat.com>
Signed-off-by: Michael Clifford <mcliffor@redhat.com>
MichaelClifford
force-pushed
the
reorganize
branch
from
4b1e0a6
to
3223e3b
Compare
lstocchi
reviewed
Mar 28, 2024
chatbot/ai-lab.yaml
Outdated
| contextdir: ../playground | ||
| containerfile: Containerfile | ||
| contextdir: ../model_servers/llamacpp_python | ||
| containerfile: ../model_servers/llamacpp_python/base/Containerfile |
There was a problem hiding this comment.
I didn't notice before but i think that the containerfile should be containerfile: ./base/Containerfile
There was a problem hiding this comment.
This is related to all ai-lab files
There was a problem hiding this comment.
Ok, was was actually not sure. It will start from the contextDir?
sallyom
reviewed
Mar 28, 2024
summarizer-langchain/ai-lab.yaml
Outdated
| contextdir: ../playground | ||
| containerfile: Containerfile | ||
| contextdir: ../model_servers/llamacpp_python | ||
| containerfile: ./model_servers/llamacpp_python/base/Containerfile |
There was a problem hiding this comment.
this needs to be ./base/Containerfile, right?
Signed-off-by: Michael Clifford <mcliffor@redhat.com>
MichaelClifford
force-pushed
the
reorganize
branch
from
9e0fe06
to
9598ecb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially Address #89 (as this is a large change, planning on breaking it up into a couple of PRs)
playground/intomodel_servers/llamacpp_python/