Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect pointer inputs to json.Unmarshal #880

Merged
merged 1 commit into from
Feb 23, 2022
Merged

Fix incorrect pointer inputs to json.Unmarshal #880

merged 1 commit into from
Feb 23, 2022

Conversation

howardjohn
Copy link
Contributor

See https://github.com/howardjohn/go-unmarshal-double-pointer for more
info on why this is not safe and how this is detected.

@howardjohn
Fix incorrect pointer inputs to json.Unmarshal
3e49ce1 
See https://github.com/howardjohn/go-unmarshal-double-pointer for more
info on why this is not safe and how this is detected.

Signed-off-by: John Howard <howardjohn@google.com>
@coveralls
Copy link

Coverage Status

Coverage remained the same at 72.322% when pulling 3e49ce1 on howardjohn:json/unmarshal-pointer into b92c836 on containernetworking:master.

matthewdupre
matthewdupre approved these changes Feb 23, 2022
View reviewed changes
Copy link
Member

@matthewdupre matthewdupre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dcbw dcbw merged commit 96a1883 into containernetworking:master Feb 23, 2022
@aojea aojea mentioned this pull request Apr 27, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewdupre matthewdupre matthewdupre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@howardjohn @coveralls @matthewdupre @dcbw