Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

skel: remove superfluous err nil check in (*dispatcher).pluginMain #864

Merged
merged 1 commit into from
Nov 8, 2021
Merged

skel: remove superfluous err nil check in (*dispatcher).pluginMain #864

merged 1 commit into from
Nov 8, 2021

Conversation

tklauser
Copy link
Contributor

There is no need to check err against nil, just return it.

@tklauser
skel: remove superfluous err nil check in (*dispatcher).pluginMain
c362597 
There is no need to check err against nil, just return it.

Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.04%) to 72.322% when pulling c362597 on tklauser:skel-superfluous-err-nil-check into 6a92df8 on containernetworking:master.

mars1024
mars1024 approved these changes Oct 27, 2021
View reviewed changes
Copy link
Member

@mars1024 mars1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm, thanks!

@tklauser
Copy link
Contributor Author

tklauser commented Nov 2, 2021

@mars1024 @mccv1r0 can this be merged given both of you approved?

@mars1024 mars1024 merged commit 1d9f32d into containernetworking:master Nov 8, 2021
@tklauser tklauser deleted the skel-superfluous-err-nil-check branch November 8, 2021 09:18
@aojea aojea mentioned this pull request Apr 27, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mars1024 mars1024 mars1024 approved these changes

@mccv1r0 mccv1r0 mccv1r0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tklauser @coveralls @mars1024 @mccv1r0