Typo fixes for infiniband GUID #764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mars1024
approved these changes
Apr 14, 2020
dcbw
reviewed
Apr 15, 2020
- Remove underscore in the Area description of the entry - Modify the capability name to be camelCase instead of underscores to be consistent with other capabilities (e.g `portMappings`, `ipRanges`) As there was no CNI released and no implementations of this capability (That i know of) i reckon we can do the attribute name adjustment. Signed-off-by: Adrian Chiris <adrianc@mellanox.com>
adrianchiris
force-pushed
the
typo-infiniband-guid
branch
from
740c6ee
to
76b18ea
Compare
dcbw
approved these changes
Apr 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to be consistent with other capabilities (e.g
portMappings,ipRanges)As there was no CNI released and no implementations of this capability
(That i know of) i reckon we can do the attribute name adjustment.
Signed-off-by: Adrian Chiris adrianc@mellanox.com