Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libcni: find plugin in exec #692

Merged
merged 1 commit into from
Jul 25, 2019
Merged

libcni: find plugin in exec #692

merged 1 commit into from
Jul 25, 2019

Conversation

mars1024
Copy link
Member

Function validatePlugin in libcni should find plugin by exec.FindInPath instead of using invoke.FindInPath directly, just like addNetwork

cni/libcni/api.go

Line 378 in df124b2

pluginPath, err := c.exec.FindInPath(net.Network.Type, c.Path)
.

I think this breaks CI of cri-o/ocicni#51.

dcbw
dcbw reviewed Jul 24, 2019
View reviewed changes
libcni/api.go Outdated Show resolved Hide resolved
@dcbw
Copy link
Member

dcbw commented Jul 24, 2019

/lgtm except for the unrelated change.

@mars1024
libcni: find plugin in exec
1318d7c 
Signed-off-by: Bruce Ma <brucema19901024@gmail.com>
@dcbw dcbw merged commit d34f7f4 into containernetworking:master Jul 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcbw dcbw dcbw left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mars1024 @dcbw