Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "Very new" and checked TODO items #84

Merged
merged 1 commit into from
May 23, 2021
Merged

Conversation

kzys
Copy link
Member

@kzys kzys commented May 21, 2021

ttrpc is not new. It has been used by containerd for years.

Fixes #59.

Signed-off-by: Kazuyoshi Kato katokazu@amazon.com

ttrpc is not new. It has been used by containerd for years.

Fixes containerd#59.

Signed-off-by: Kazuyoshi Kato <katokazu@amazon.com>
@codecov-commenter
Copy link

Codecov Report

Merging #84 (dcc7d39) into master (8ecd516) will decrease coverage by 0.81%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #84      +/-   ##
==========================================
- Coverage   69.77%   68.95%   -0.82%     
==========================================
  Files          11       11              
  Lines         612      612              
==========================================
- Hits          427      422       -5     
- Misses        149      153       +4     
- Partials       36       37       +1     
Impacted Files Coverage Δ
server.go 71.60% <0.00%> (-2.06%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25f5476...dcc7d39. Read the comment docs.

@fuweid fuweid merged commit 06c1124 into containerd:master May 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Is the status note still correct? "Very new. YMMV."
4 participants