Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regressions #414

Merged
merged 3 commits into from
Mar 21, 2022
Merged

Fix regressions #414

merged 3 commits into from
Mar 21, 2022

Conversation

djc
Copy link
Member

@djc djc commented Mar 21, 2022

Fixes #412, #413.

While we previously removed the ProgressBar's state from the
MultiProgressState, we did not remove the remote draw target
from the bar's draw target, so that it could start to draw
into the MultiProgress state again in surprising ways.
djc added 2 commits March 20, 2022 20:51
This might hide the panic output, making it extremely confusing
how the process might have ended.
In #395, we made it so that message and prefix are carried over
when calling ProgressBar::with_style(), but this did not change
ProgressBar::set_style(). Reuse the same logic by having
with_style() call set_style(), so that these cannot fall out of
sync again.
Copy link
Collaborator

@chris-laplante chris-laplante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@djc djc merged commit 0fe51c2 into main Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MultiProgress example indentation prefixes are sometimes not drawn
2 participants