Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for the Redirect link for the edit source #652

Merged
merged 4 commits into from
Feb 28, 2023
Merged

Fix for the Redirect link for the edit source #652

merged 4 commits into from
Feb 28, 2023

Conversation

RahulARanger
Copy link
Contributor

@RahulARanger RahulARanger commented Feb 25, 2023

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add/update necessary tests?
  • Add/update outdated documentation?

Description

Hi, The Pull request for the following things:

  1. To fix the Edit Source Link in the existing documentation, Previously we were referring to the https://github.com/conda/constructor/edit/main/docs/... expected: https://github.com/conda/constructor/edit/main/docs/source/...
  2. emphasized .exe along with packages for macOS and Linux in the page: Getting Started

image

3. Removed a Preposition "of" in Getting Started Page

@RahulARanger RahulARanger requested a review from a team as a code owner February 25, 2023 20:41
@conda-bot
Copy link
Contributor

We require contributors to sign our Contributor License Agreement and we don't have one on file for @RahulARanger.

In order for us to review and merge your code, please e-sign the Contributor License Agreement PDF. We then need to manually verify your signature. We will ping the bot to refresh the PR status when we have confirmed your signature.

@jaimergp
Copy link
Contributor

Thanks!

Can you also add a news file? Once you've signed the CLA, we can merge.

@RahulARanger
Copy link
Contributor Author

Thanks!

Can you also add a news file? Once you've signed the CLA, we can merge.

Done, is it possible to ping CLA Check again?

@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Feb 28, 2023
@jaimergp
Copy link
Contributor

Done, is it possible to ping CLA Check again?

@dbast can you check please? 🙏

@jaimergp
Copy link
Contributor

Oh, it's checked. Cool. Then we can merge once CI is passing :D

@jaimergp jaimergp merged commit fd792de into conda:main Feb 28, 2023
@jaimergp
Copy link
Contributor

Thanks!

@jaimergp jaimergp mentioned this pull request Jun 19, 2023
31 tasks
@github-actions github-actions bot added the locked [bot] locked due to inactivity label Feb 29, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed [bot] added once the contributor has signed the CLA locked [bot] locked due to inactivity
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants