Install NSIS logging variant via conda (instead of manually installing it) #632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g it) This improves the CI reliability as sourceforge is sometimes hard to reach.
conda-bot
added
the
cla-signed
|
seems to work, from the CI log: |
jaimergp
reviewed
Jan 26, 2023
|
Can you please add the news item? I'll approve then! |
jaimergp
reviewed
Jan 26, 2023
jaimergp
approved these changes
Jan 26, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This improves the CI reliability as sourceforge is sometimes hard to reach.
(conda, conda-build, conda-pack etc... also all use conda-forge packages during CI ... nsis has no run dependencies so getting it from another channel is no problem)
closes #631
Checklist - did you ...
newsdirectory (using the template) for the next release's release notes?